Improve object name display in viewer #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the behavior in the viewer so that object names aren't shown if the object itself is not shown. Also support showing named detections, not just annotations.
finglis
approved these changes
Aug 9, 2024
Don't paint detection names if we aren't at full resolution or above. This enables us to avoid introducing sluggishness in the UI when there are very large numbers of detections, by needing to access them on every repaint irrespective of whether there are names to show.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the behavior in the viewer so that object names aren't shown if the object itself is not shown. Also support showing named detections, not just annotations.