feat: make certain ds fields optional and test #9

asim-shrestha · 2021-02-24T01:19:58Z

closes #8

awtkns

We should also bump the version

tests/conftest.py

tests/test_rtstruct_builder.py

tests/test_ds_helper.py

rt_utils/ds_helper.py

refactor: add blank lines to EOF Co-authored-by: Adam Watkins <32209255+awtkns@users.noreply.github.com>

…TStruct into 8-optinal-fields

feat: make certain ds fields optinal and test

6d588a4

asim-shrestha requested a review from awtkns February 24, 2021 01:19

asim-shrestha changed the title ~~feat: make certain ds fields optinal and test~~ feat: make certain ds fields optional and test Feb 24, 2021

awtkns approved these changes Feb 24, 2021

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

tests/test_rtstruct_builder.py Outdated Show resolved Hide resolved

tests/test_ds_helper.py Outdated Show resolved Hide resolved

rt_utils/ds_helper.py Show resolved Hide resolved

asim-shrestha and others added 3 commits February 23, 2021 20:00

Apply suggestions from code review

8fde648

refactor: add blank lines to EOF Co-authored-by: Adam Watkins <32209255+awtkns@users.noreply.github.com>

refactor: bump version and add comment back

1345ade

Merge branch '8-optinal-fields' of https://github.com/qurit/Mask-to-R…

8e78e45

…TStruct into 8-optinal-fields

asim-shrestha merged commit 8c18a38 into main Feb 24, 2021

awtkns deleted the 8-optinal-fields branch February 24, 2021 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: make certain ds fields optional and test #9

feat: make certain ds fields optional and test #9

asim-shrestha commented Feb 24, 2021

awtkns left a comment

feat: make certain ds fields optional and test #9

feat: make certain ds fields optional and test #9

Conversation

asim-shrestha commented Feb 24, 2021

awtkns left a comment

Choose a reason for hiding this comment