Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow new formulation in terms of cumulant expansion #27

Merged
merged 83 commits into from
Oct 11, 2020
Merged

Follow new formulation in terms of cumulant expansion #27

merged 83 commits into from
Oct 11, 2020

Conversation

thangleiter
Copy link
Member

Implement the new formulation in terms of a cumulant expansion. This mostly involves:

  • rename "error vector correlation functions" to "decay amplitudes"
  • introduce the cumulant function
  • calculate the error transfer matrix as the matrix exponential of the cumulant function

@thangleiter
First draft to calculate noise operators instead of control matrices
47d2af6
@thangleiter
Improve performance
2da0cf7
@thangleiter
remove artefacts from other branch
5cf6626
@thangleiter
remove artefacts from other branch 2
c2feab9
@thangleiter
remove artefacts from other branch 2
782371c
@thangleiter
Merge branch 'feature/calculation_with_unitaries' of https://git.rwth…
c2ddb9e 
…-aachen.de/tobias.hangleiter/python-filter_functions into feature/calculation_with_unitaries
@thangleiter
Rename error vector correlation functions --> decay amplitudes
674ed30
@thangleiter
Add calculate_cumulant_function as intermediate
67c734e 
New flow: error_transfer_matrix -> calculate_cumulant_function ->
calculate_decay_amplitudes
@thangleiter
Add pulse correlation decay amplitudes
a19ae06 
Also refactor internal function _get_integrand
@thangleiter
Make code more readable, update infidelity docstr
d3c5519
@thangleiter
Fix bugs and tests
077e8b0
@thangleiter
Make symmetrize_spectrum work with cross-correlated spectra
1b67005
@thangleiter
Update documentation
5b4cb08
@coveralls
Copy link

coveralls commented Jun 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 182

  • 144 of 144 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 95.467%
Totals Coverage Status
Change from base Build 161: 0.5%
Covered Lines: 1849
Relevant Lines: 1915
💛 - Coveralls

@thangleiter
Small changes to docstrings
4ff9fe4
@thangleiter
Allow computing error transfer matrix from precomputed cumulant function
4f7e020
@thangleiter
Update example scripts
6fac17f
@thangleiter
Use tensordot instead of einsum in basis.expand
df99d49 
Also fix rand_unit for 1d
@thangleiter
Fix bug for pulse correlation decay amps
4bc415a
@thangleiter
Add test for which='total'/'correlations' argument
706c802
@thangleiter
Test Exceptions in error_transfer_matrix
1d69b58
@thangleiter
Test calculation of error transfer matrix from K
94f6a81
@thangleiter
Use FF to calculate integrand if available
42a4d63 
This removes unnecessary double calculations
@thangleiter
Update readme with new is_cached aliases
c469b76 
diff --git a/README.md b/README.md
index bba48f6..24c15d6 100644
--- a/README.md
+++ b/README.md
@@ -46,7 +46,7 @@ Y2.cache_filter_function(omega)
 X.cache_filter_function(omega)

 hadamard = Y2 @ X           # equivalent: ff.concatenate((Y2, X))
-hadamard.is_cached('F')
+hadamard.is_cached('filter function')
 # True  (filter function cached during concatenation)
 ```
@thangleiter
Fix integration
7381d84
@thangleiter
Add test for numeric._get_integrand()
c3d4076
@thangleiter
Make fidelity comparison more lenient
85ded21
@thangleiter
atol instead of rtol
9a88506
@thangleiter
Test calc_cumulant_function for R=None and F=None
2a54499
@thangleiter
Make parse_optional_parameter accept multiple params.
ca21477
@thangleiter
Refactor algorithm calculating control matrix
db39d5a 
 * Factor out some core computations into dedicated functions. This
   makes the code more readable.

 * Use util.cexp - 1 instead of np.expm1 to compute the integral. This
   should be significantly faster with negligible precision loss.

 * Use opt_einsum.contract_expression instead of np.einsum for the core
   computation. This should be faster by a factor of 1..1.5
@thangleiter
Merge branch 'feature/follow_new_formulation' into feature/calculatio…
09db28f 
…n_with_unitaries
@thangleiter
Add/update docstring, clean up ..._from_atomic
571cf0f
@thangleiter
Clean & speed up calculate_noise_operators_from_xxx
21eb5d3
@thangleiter
Rename E -> omega
f580df2
@thangleiter
replace l->g in docstrings
a5dddd3
@thangleiter
Fix bug where array wasn't initialized
4d072f0
@thangleiter
Add test
0692683
@thangleiter
Comply with old numpy random API
b2be2b9
@thangleiter
Add documentation on how to obtain control matrix
364e9ce
@thangleiter
Update notation in doc
879e4b4
@thangleiter
Remove .rst file that is automatically generated at runtime of the do…
c5dbc80 
…c build
@thangleiter
Seems like sphinx-build doesn't generate the file, only when running …
dd1dff7 
…make
@thangleiter
Simplify calculation of choi matrix
a9cb2b8
@thangleiter
Fix indentation and use of l as variable
76ce994
@thangleiter
Merge branch 'feature/follow_new_formulation' into feature/calculatio…
7bdc06a 
…n_with_unitaries
@thangleiter
Add functionality to cache intermediate quantities
d7338cf 
This is useful for derivatives and second order calculations.
@thangleiter
Add test for non-Pauli basis in extend
ea82e54
@thangleiter
Remove not needed out kwarg
63acf82
@thangleiter
Merge branch 'feature/follow_new_formulation' into feature/calculatio…
68d44f5 
…n_with_unitaries
@thangleiter
Merge branch 'feature/calculation_with_unitaries' of https://github.c…
6b48034 
…om/qutech/filter_functions into feature/calculation_with_unitaries
@thangleiter
Remove erroneously added files from other branch
90506e5
@thangleiter
Allow reuse of intermediates in calculate_control_matrix_from_scratch
23bfe8b
@thangleiter
Revert some of the previous changes
904f435 
Adds minor performance improvements for an edge case while adding lots
of code complexity
@thangleiter
Merge pull request #37 from qutech/feature/calculation_with_unitaries
6bc10d8 
Calculation with unitaries
@thangleiter
Merge branch 'feature/follow_new_formulation' into feature/cache_inte…
38fa4a6 
…rmediates
@thangleiter
Merge branch 'master' into feature/follow_new_formulation
2412daf
@thangleiter
Merge pull request #39 from qutech/feature/cache_intermediates
f4b312e 
Feature/cache intermediates
@thangleiter thangleiter merged commit e2c5c3e into master Oct 11, 2020
@thangleiter thangleiter deleted the feature/follow_new_formulation branch December 1, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thangleiter @coveralls