Fix issues 271&281 #285
Merged
Fix issues 271&281 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes method flush() obsolete, so it was removed.
JSONEncoder previously did not check whether subpulses are identical to already known pulses with the same id but just replaced them with a reference to the already known subpulse in the serialization. This could lead to unexpected behavior. JSONEncoder now raises a RuntimeError instead in this case. PulseStorage adopts a transaction model and takes care that in case of such an exception, a pulse is not partially serialized, i.e., if a pulse serialization aborts due to a duplicated subpulse identifier, no changes to the storage is made (that is, new subpulses that were already succesfully serialized will be discarded if an error is encountered for another subpulse).
terrorfisch
reviewed
Jul 5, 2018
qctoolkit/serialization.py
Outdated
|
|
||
| self._temporary_storage[identifier] = self.StorageEntry(serialized, serializable) | ||
| if is_transaction_begin: | ||
| for id in self._transaction_storage: |
There was a problem hiding this comment.
Please do not overwrite builtins
Signed-off-by: Lukas Prediger <lukas.prediger@rwth-aachen.de>
NestedDummySerializable's constructor now passed the registry argument through to superclass. Signed-off-by: Lukas Prediger <lukas.prediger@rwth-aachen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #271 and closes issue #281