Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for new serialization #297

Merged
merged 2 commits into from
Jul 12, 2018
Merged

Fixes for new serialization #297

merged 2 commits into from
Jul 12, 2018

Conversation

lumip
Copy link
Contributor

@lumip lumip commented Jul 9, 2018

Fixed:

  • MappingPT did not implement the new serialization (and had no dedicated serialization tests)
  • Several implementations of get_serialization_data and deserialize in test dummies did not have the update signature and required a Serializer object to be passed as positional parameter

lumip added 2 commits July 9, 2018 16:05
@lumip
Fix: MappingPulseTemplate had no implementation for new serialization…
52fbbc5 
… routines.

Also added tests (these were also missing for the old serialization routines!).
@lumip
Ensured that no occurrence of get_serialization_data/deserialize requ…
248b777 
…ires a Serializer object as non-optional positional argument anymore.
@lumip lumip added this to the New Serialization Routines milestone Jul 9, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.994% when pulling 248b777 on issues/250_fix_mapping_pt into bb757a0 on issues/250_serialization.

@lumip lumip merged commit ac78907 into issues/250_serialization Jul 12, 2018
@lumip lumip deleted the issues/250_fix_mapping_pt branch July 12, 2018 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
New Serialization Routines
Development

Successfully merging this pull request may close these issues.
2 participants
@lumip @coveralls