Serialization conversion script #304
Conversation
…format. Pulse is read using old serialization routines from a source storage backend and destination storage backend to a new using the new routines.
Method should list all available serializables. No tests currently.
convert_pulses_in_storage converts all pulses in a given source StorageBackend from the old serialization format into the new and stores them in a given destination StorageBackend. Both conversion methods now raise an exception if they would need to overwrite identifiers already existing in the destination backend. Commit also includes more extensive tests for both conversion methods as well as some style corretions for already existing tests.
…' into issues/250_serialization_conversion_script
…_conversion_script
Ensures that the conversion using convert_pulses_in_storage() results in an equal PulseTemplate.
| @@ -609,7 +645,7 @@ def deserialize(self, representation: Union[str, Dict[str, Any]]) -> Serializabl | |||
| if isinstance(representation, str): | |||
| if representation in self.__subpulses: | |||
| return self.__subpulses[representation].serializable | |||
|
|
|||
There was a problem hiding this comment.
Please cleaun up to avoid merge conflicts
| @@ -141,6 +150,21 @@ def delete(self, identifier): | |||
| except FileNotFoundError as fnf: | |||
| raise KeyError(identifier) from fnf | |||
|
|
|||
| def list_contents(self) -> Set[str]: | |||
| contents = set() | |||
| for dirpath, dirs, files in os.walk(self._root): | |||
There was a problem hiding this comment.
os.walk goes through the complete tree. We only return top level jsons in FilesystemBackend.get
There was a problem hiding this comment.
Which is why there's a line 159 which aborts the iteration after the first level. The reason to still use os.walk() was that it conveniently separates dirs and files and gives me the base dirpath as well in one single call.
| @@ -91,6 +92,14 @@ def delete(self, identifier: str) -> None: | |||
| def __delitem__(self, identifier: str) -> None: | |||
| self.delete(identifier) | |||
|
|
|||
| @abstractmethod | |||
| def list_contents(self) -> Set[str]: | |||
There was a problem hiding this comment.
I suggest naming the method keys
There was a problem hiding this comment.
I think list_contents() is a more fitting name for what is going on here since the method returns a list of the (available) contents of the storage backend. keys() is a much more generic name and restricts to a plain dictionary "view" of the interface without regarding the context.. I guess it's more "pythonic" though.. ultimately, I don't really care
There was a problem hiding this comment.
I think sticking to list_contents is better as we are not returning a view. The return value of a keys method should update if the content of the mapping changes.
…_conversion_script
Methods convert_stored_pulse_in_storage() and convert_pulses_in_storage() to convert a specified or all pulses from a source storage where the are stored by the old serialization routines to a new destination backend using the new serialization routines.
Closes #296