Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/298 early pulse registration #307

Merged

Conversation

lumip
Copy link
Contributor

@lumip lumip commented Jul 12, 2018

No description provided.

…re they serialize correctly.

Signed-off-by: Lukas Prediger <lukas.prediger@rwth-aachen.de>
…global registry after they are completely initialized.

Serializable now does not perform registration in __init__ but provides a method _register() which MUST be called by leaf-level subclasses. (This is probably also not a good solution in the long term as it effectively prevents further subclassing from those classes but it works for now).

Signed-off-by: Lukas Prediger <lukas.prediger@rwth-aachen.de>
@coveralls
Copy link

coveralls commented Jul 12, 2018

Coverage Status

Coverage increased (+0.01%) to 94.074% when pulling f638d24 on issues/298_early_pulse_registration into 62d18ad on issues/250_serialization.

@terrorfisch terrorfisch merged commit b796ab1 into issues/250_serialization Jul 12, 2018
@lumip lumip deleted the issues/298_early_pulse_registration branch July 13, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants