Prepare the qutip-qip-0.2.3 release #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the SCQubits simulator
* add version test for definition of rand_unitary * fix usage of rand_ket and rand_unitary
Fix the final time calculation in `_concatenate_pulses`.
* Fix bug for circuit with selected measurement result The parameter measure_results was not correctly processed in QubitCircuit.run because the Simulator is initialized twice. This commit removes the parameters `state`, `cbits` and `measure_results` from the `__init__` of CircuitSimulator and only initializes the simulator before it is run. The CircuitSimulator class should only include information about the circuit while the information about the state is only provided when running the simulation.
* Fix bugs in the analytical pulse shapes - Fix bugs in the analytical pulse shapes - Compress the test. The test no longer depends on the processor class. Test both the maximum and the total area.
- Add a minus sign for plotting the swap gate - Add a border so that SWAP gates are not cropped. - Remove the unnecessary redefinition of qswap
qutip 5 uses more recently syntax and no longer support Python 3.6.
hodgestar
approved these changes
Oct 26, 2022
SWAP needs to be treated differently for circuits with reversed and non-reversed states order.
Co-Authored-By: Simon Cross <165551+hodgestar@users.noreply.github.com>
Use the atol option in qutip to determine the tolerance for measurement. And filter out the states with a probability smaller than this.
Add a default max_step based on the total circuit time. This does not solve the problem completely. But it will avoid those mistakes that keep popping up when people try and compile one gate and send it to the solver. When there are more gates and a non-trivial circuit, the probability of this happening will be very low.
BoxiLi
force-pushed
the
qutip-qip-0.2.X
branch
from
675ed29
to
38b5974
Compare
|
It's always hard to review these, but it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.