Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links tutorials #54

Merged
merged 6 commits into from
Jun 14, 2021
Merged

Links tutorials #54

merged 6 commits into from
Jun 14, 2021

Conversation

purva-thakre
Copy link
Contributor

@purva-thakre purva-thakre commented Jun 13, 2021

As discussed in #33, links to tutorials are added in documentation and readme.md.

For the moment, haven't changed the anchor as requested in above issue since Boxi had a PR for it.

@nathanshammah nathanshammah self-requested a review June 13, 2021 14:09
Copy link
Member

@nathanshammah nathanshammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @purva-thakre. It looks good.

Actually, the other day, I was really looking for this. It would be great to also add an item to the menu bar on the left, for easy access. This can lead to a short .rst page that contains a link to the qutip docs. What do you think?

@purva-thakre
Copy link
Contributor Author

@nathanshammah I like adding the idea for a new rst page. Let me know what information you would prefer to be added to this. Right now, I moved the line in in the introduction page to tutorials page.

Copy link
Member

@nathanshammah nathanshammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@BoxiLi
Copy link
Member

BoxiLi commented Jun 13, 2021

I was wondering, maybe it looks better if the tutorial is added after the user guide? The user guide first introduces necessary concepts, and the tutorials provide hands-on code examples.

@nathanshammah
Copy link
Member

Looks good, Purva, and thanks for the additional review, Boxi.

@nathanshammah nathanshammah merged commit 7ef0158 into qutip:master Jun 14, 2021
@purva-thakre purva-thakre deleted the patch-1 branch June 14, 2021 15:16
@BoxiLi BoxiLi added this to the qutip-qip-0.1.1 milestone Jul 7, 2021
BoxiLi pushed a commit to BoxiLi/qutip-qip that referenced this pull request Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants