Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename get_noisy_dynamics to get_noisy_pulses #76

Merged
merged 4 commits into from
Jul 18, 2021
Merged

Rename get_noisy_dynamics to get_noisy_pulses #76

merged 4 commits into from
Jul 18, 2021

Commits on Jul 11, 2021

  1. rename get_noisy_dynamics to get_noisy_pulses 

    In the noise module, users are allowed to define custom noise for their own physical model. The `Noise` class uses a hook method `get_noisy_dynamics` to realize this. This method will be called when including noise in the physical model.

However, the name `get_noisy_dynamics` was wrong because the noise object returns a list of `Pulse`, instead of `QobjEvo`. This PR fixed this issue and use the term `get_noisy_pulses`. The old API is still usable but will issue a `PendingDeprecationWarning`.
    @BoxiLi
    BoxiLi committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    6d2696b View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Update src/qutip_qip/noise.py 

    Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
    @BoxiLi @hodgestar
    BoxiLi and hodgestar authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    2317ea6 View commit details
    Browse the repository at this point in the history

  2. Update src/qutip_qip/noise.py 

    Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
    @BoxiLi @hodgestar
    BoxiLi and hodgestar authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    7571066 View commit details
    Browse the repository at this point in the history

  3. Update src/qutip_qip/noise.py 

    Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
    @BoxiLi @hodgestar
    BoxiLi and hodgestar authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    8c4275b View commit details
    Browse the repository at this point in the history