Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Pow specialisation was being added to expm dispatcher. #23

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

AGaliciaMartinez
Copy link
Member

@AGaliciaMartinez AGaliciaMartinez commented Aug 15, 2021

I really think that adding an assert in the Tests for the specialisations that checks whether the tested specialisation have been added correctly would prevent this kind of mistakes. It would only have to check whether the _specialisations attribute has the new specialisation that is being tested.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1133098068

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.553%

Totals Coverage Status
Change from base Build 1112911961: 0.0%
Covered Lines: 243
Relevant Lines: 257

💛 - Coveralls

@AGaliciaMartinez AGaliciaMartinez merged commit e2caaa9 into qutip:main Aug 15, 2021
@AGaliciaMartinez AGaliciaMartinez deleted the quick_fix_pow branch August 15, 2021 17:21
@AGaliciaMartinez
Copy link
Member Author

I will simply merge this PR as the fix is simple and I need this for another PR to work.

@coveralls
Copy link

coveralls commented Oct 9, 2024

Pull Request Test Coverage Report for Build 1133098068

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.553%

Totals Coverage Status
Change from base Build 1112911961: 0.0%
Covered Lines: 243
Relevant Lines: 257

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants