Merge pull request #17 from tarent/no-post-responses-from-cache

do not fetch results out of the cache if it is no GET request

composition/cache_loader.go

@@ -25,9 +25,11 @@ func NewCachingContentLoader(cache Cache) *CachingContentLoader {
 func (loader *CachingContentLoader) Load(fd *FetchDefinition) (Content, error) {
 	hash := fd.Hash()
 
-	if cFromCache, exist := loader.cache.Get(hash); exist {
-		logging.Cacheinfo(fd.URL, true)
-		return cFromCache.(Content), nil
+	if fd.Method == "GET" {
+		if cFromCache, exist := loader.cache.Get(hash); exist {
+			logging.Cacheinfo(fd.URL, true)
+			return cFromCache.(Content), nil
+		}
 	}
 	logging.Cacheinfo(fd.URL, false)
 	c, err := loader.load(fd)

composition/cache_loader_test.go

@@ -33,6 +33,32 @@ func Test_CacheLoader_Found(t *testing.T) {
 	a.Equal(c, result)
 }
 
+func Test_CacheLoader_NoLookupForPostRequests(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+	a := assert.New(t)
+
+	// given:
+	fd := NewFetchDefinition("/foo")
+	fd.Method = "POST"
+	c := NewMemoryContent()
+	c.url = "/foo"
+
+	// and a cache returning nothing
+	cacheMocK := NewMockCache(ctrl)
+	httpLoaderMocK := NewMockContentLoader(ctrl)
+	httpLoaderMocK.EXPECT().Load(gomock.Any()).Return(c, nil)
+
+	// when: we load the object
+	loader := NewCachingContentLoader(cacheMocK)
+	loader.httpContentLoader = httpLoaderMocK
+
+	// it is returned
+	result, err := loader.Load(fd)
+	a.NoError(err)
+	a.Equal(c, result)
+}
+
 func Test_CacheLoader_NotFound(t *testing.T) {
 	tests := []struct {
 		url      string
@@ -41,7 +67,6 @@ func Test_CacheLoader_NotFound(t *testing.T) {
 	}{
 		{"http://example.de", "GET", true},
 		{"file:///some/file", "GET", true},
-		{"http://example.de", "POST", false},
 	}
 	for _, test := range tests {
 		ctrl := gomock.NewController(t)