Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let upstream middleware (e.g. fastcgi and cgi) know about authenticated user #95

Closed
wants to merge 4 commits into from

Conversation

magikstm
Copy link
Contributor

@magikstm magikstm commented Dec 9, 2018

Fixes #94.

Tested on Windows 7 x64 with PHP 7.3.0 and it sets value for $_SERVER['REMOTE_USER']. This value is empty when user isn't logged in.

Implemented like Caddy's basicauth:
https://github.com/mholt/caddy/blob/master/caddyhttp/basicauth/basicauth.go#L80

I tried adding tests, but I've not been able to for now.

@coveralls
Copy link

coveralls commented Dec 9, 2018

Coverage Status

Coverage increased (+0.02%) to 90.585% when pulling 9d6e8b0 on magikstm:issue-94 into 23bd16e on tarent:master.

@magikstm magikstm closed this Dec 9, 2018
@magikstm magikstm deleted the issue-94 branch December 9, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants