Implementations #2
Conversation
There was a problem hiding this comment.
Hi @qwibbler
Good job so far! Your code looks fine, good job 👍 👍
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight:
- Great job with the project it looks really good 💪
Required Changes ♻️
- Check inline comments for more information ⏬
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| @@ -0,0 +1,13 @@ | |||
| export const saveDataLocation = 'myLocalToDo'; | |||
There was a problem hiding this comment.
- Kindly take a step back here because when I reload the page my completed items are not being saved
There was a problem hiding this comment.
I wanted to ask, is the local storage not being saved at all, or just initially?
Because I just fixed the initial save problem, but otherwise it always saves for me, whenever I make changes to it, even in a different browser.
There was a problem hiding this comment.
As pointed by the previous reviewer,
- The updated array of items is stored in local storage, so the user gets the correct list values after the page reloads.
There was a problem hiding this comment.
Sorry, I just realized, I hadn't pushed my latest code 😥 .
Can you just tell me if it will work now, please?
There was a problem hiding this comment.
Hi @qwibbler
Great work on making the project requirements 👏
You've done well implementing some of the project requirements, but there are still some which aren't addressed yet, please work on it and ask for another review.
Required Changes ♻️
Check the comments under the review.
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Approved project! 💯 ✅ 🥳 🎈 🎉
Hi @qwibbler
Amazing job implementing suggestions from the previous reviewer! 💯
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Aspects to improve ♻️
Check the comments under the review.
- [OPTIONAL] It would be better to fix the broken MIT link in your README file.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Import module with function to toggle complete and update list accordingly.
Import module with function to save/get list from local storage.