增加视频字幕一对多功能 #54
Merged
增加视频字幕一对多功能 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- Detect if multiple subtitles exist for a single video - Retain language suffix if one-to-many mapping is found - Improve merging of items with same keys - Group items by non-empty keys and merge them - Ensure the first non-empty video and all non-empty subtitles are kept - Keep items with empty keys unchanged - Update method signature to accept IReadOnlyList
|
谢谢你提交 PR！你的修改思路非常好 为了方便测试，我改了下代码：不再做引用类型的函数输入值修改（in-place 修改），而是创建一个新 List 然后输出。其次，输入值的数据类型改成了 IReadOnlyList，防止修改传入的数据（去掉函数的副作用）。 还有保留语言后缀的开关，逻辑我改成了：检查是否存在视频字幕一对多的情况，若存在则保留语言后缀。（之前是用户点了「保留全部文件」才自动打开）。 这个「选择保留语言」的对话框其实有点烦，以后可以增加一个新的选项，可以选择禁用掉这个功能。 我写了许多新的测试用例，在这里，本 PR 已通过测试，看看还有没有其他需要的补充。 然后文件列表匹配整个执行流程也有测试用例了，在这个地方，有需要可以补充。 在命令行运行 
|
qwqcode
approved these changes
Sep 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改了
MergeSameKeysItems中的匹配规则，筛选出字幕文件并与视频文件配对后删除已配对的视频item，实现视频和字幕一对多匹配。同时在选择全部保留时自动勾选保留语言后缀选项防止重命名失败。