Issue 364 remote options fix #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument, moved the remote urls to remote_url_conf
… into issue_364_remote_options_fix
This was
linked to
issues
Mar 26, 2024
shivahari
requested changes
Mar 29, 2024
| #The URLs for connecting to BrowserStack and Sauce Labs. | ||
|
|
||
| browserstack_url = "http://hub-cloud.browserstack.com/wd/hub" | ||
| saucelabs_url = "https://ondemand.eu-central-1.saucelabs.com:443/wd/hub" |
There was a problem hiding this comment.
Can you remove the port number from the url?
Using HTTPS will make it use 443, we can skip adding the port number in the URL
There was a problem hiding this comment.
We could create this as new issue
shivahari
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote testing ( browserstack and saucelabs) would be taking the parameters as which browser /version to test .
However noticed that the option passing as browser is throwing error message as "list index out of range"
While we run the test using the command
python -m pytest tests/test_example_form.py --remote_flag Y --browser firefox
Fixed this issue .
Changed files :
conftest.py
page_objects/driverfactory.py
Added file :
remote_url_conf.py
How to test :
Run the test with the remote options it should take the partial options and go with the default ones . If not browser option provided , it will ask for it
python -m pytest tests/test_example_form.py --remote_flag Y --browser firefox
Will pass
python -m pytest tests/test_example_form.py --remote_flag Y --ver 122 will take the default browser and the updated version that pass .