get resume id from server #134
Conversation
|
LGTM. |
|
IQ parsing / serialization is trivial to unit test, so do it :) |
jlaine
force-pushed
the
master
branch
4 times, most recently
from
81b12d9
to
cd81054
Compare
|
@coderlxn can we please have a unit test for this so we can merge it? |
|
@lnjX I'm not sure I understand what this does anymore, ideas? |
| @@ -132,6 +132,7 @@ void QXmppStreamManagementEnabled::parse(const QDomElement &element) | |||
| m_resume = resume == QString("true") || resume == QString("1"); | |||
| m_max = element.attribute("max").toUInt(); | |||
| m_location = element.attribute("location"); | |||
| m_id = element.attribute("id"); | |||
There was a problem hiding this comment.
This only adds parsing, we also need to add this in ::toXml.
just in case someone actually wants to use the QXmppServer ;)
|
@jlaine The session id needs to be parsed to be able to resume the session (using |
|
@jlaine What kind of unit test should I add for this pull request? Sorry, I'm not familiar with the progress of pull request. |
|
Unfortunately there's no test class for stream management, yet, but you could base on this test basically. It were also nice to have this new test class in a new commit. |
lnjX
force-pushed
the
master
branch
10 times, most recently
from
84168ac
to
e614dcc
Compare
|
Parsing of the id attribute has been added in the meantime, so this is obsolete. |
No description provided.