Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provisioning support for custom websocket ports #1263

Merged
merged 7 commits into from
May 6, 2024
Merged

Conversation

tresf
Copy link
Contributor

@tresf tresf commented May 3, 2024

Adds support for specifying custom websocket ports in qz-tray.properties as well as provisioning.json

provisioning.json

[
    {
        "description": "Custom secure websocket ports",
        "type": "property",
        "data": "websocket.secure.ports=9191,9292,9393,9494"
    },
    {
        "description": "Custom insecure websocket ports",
        "type": "property",
        "data": "websocket.insecure.ports=9192,9293,9394,9495"
    }
]
ant -Dprovision.file=provision.json nsis

Testing:

  1. Install the software, verify everything works on the custom port
  2. Check the firewall rules are installed for the custom port:
    • Start, Run:wf.msc, Inbound Rules, "QZ Tray"

Closes #1071

@tresf tresf requested a review from Vzor- May 3, 2024 05:26
src/qz/installer/provision/ProvisionInstaller.java Outdated Show resolved Hide resolved
src/qz/ws/PrintSocketServer.java Outdated Show resolved Hide resolved
@tresf tresf merged commit ac5c6c1 into master May 6, 2024
6 checks passed
@tresf tresf deleted the custom-ports branch May 6, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to specify custom websocket ports
2 participants