RPP Test suite : Modifications to support python 2 #288
Conversation
HazarathKumarM
commented
Jul 11, 2024
HazarathKumarM
commented
- Adds changes to support tests for all the versions of python
| result = subprocess.run([buildFolderPath + "/build/Tensor_misc_hip", str(case), str(testType), str(toggle), str(numDims), str(batchSize), str(numRuns), str(additionalArg), outFilePath, scriptPath], stdout=subprocess.PIPE) # nosec | ||
| print(result.stdout.decode()) | ||
| print("./Tensor_misc_hip {} {} {} {} {} {} {}".format(case, testType, toggle, numDims, batchSize, numRuns, additionalArg)) | ||
| result = subprocess.Popen([buildFolderPath + "/build/Tensor_misc_hip", str(case), str(testType), str(toggle), str(numDims), str(batchSize), str(numRuns), str(additionalArg), outFilePath, scriptPath], stdout=subprocess.PIPE) # nosec |
There was a problem hiding this comment.
Why the change from subprocess.run to subprocess.Popen here?
There was a problem hiding this comment.
.run methos is only introduced in python3.5 , so we need to change it to Popen to support running in python2
| subprocess.run(["cmake", scriptPath], cwd=".") # nosec | ||
| subprocess.run(["make", "-j16"], cwd=".") # nosec | ||
| subprocess.call(["cmake", scriptPath], cwd=".") # nosec | ||
| subprocess.call(["make", "-j16"], cwd=".") # nosec |
There was a problem hiding this comment.
What's the difference in changing from run to call? vs the Popen above?
There was a problem hiding this comment.
.call returns either 0 or 1 as output, in the above case we need to print the log in terminal and as well as to the log file , we need stdout to be returned from the subprocess, Popen return that log
utilities/test_suite/HIP/runTests.py
Outdated
| os.makedirs(f"{dstPath}/Tensor_PLN1") | ||
| os.makedirs(f"{dstPath}/Tensor_PLN3") | ||
| os.makedirs("{}/Tensor_PKD3".format(dstPath)) | ||
| os.makedirs("{}/Tensor_PLN1".format(dstPath)) |
There was a problem hiding this comment.
Doesn't string concatenation work for all Python versions? Like using (dstPath + "/Tensor_PKD3")?
Or is the .format() useful somewhere else?
There was a problem hiding this comment.
changed to concatenation
|
@r-abishek currently there are no deprecation warnings for .call() and .Popen() methods |
