Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'rustfmt' is not installed for the toolchain #3

Closed
qvignaud opened this issue Jul 10, 2024 · 3 comments
Closed

'rustfmt' is not installed for the toolchain #3

qvignaud opened this issue Jul 10, 2024 · 3 comments

Comments

@qvignaud
Copy link

Hello,

I'm currently trying to use this crate but it cannot be compiled due to the build script requiring rustfmt, however this tool is not installed on the official Rust build images (https://hub.docker.com/_/rust), nor it is on many build environments.

I don't know if it can be called a bug or a misconception, as build scripts should not rely on such tools being present (nor even really care about formatting of the code).

In my case it's out of question to change anything in the build environment "just" to have some DNS resolution features.

I can only recommend you to remove this requirement for future users, otherwise this lib seems really to be a good tool, even if I'm a bit surprised by the way it is implemented.
@r-bk
Copy link
Owner

r-bk commented Jul 10, 2024

@qvignaud Thanks for reporting this.
Indeed, rustfmt shouldn't be required in the build script.
I will make this step a best-effort.

r-bk added a commit that referenced this issue Jul 10, 2024
@r-bk
build: make code formatting a best-effort
dc6d24c 
This commit makes the `format_file` function a best effort, to not fail
the build on toolchains where `rustfmt` isn't installed.

This handles #3.
r-bk added a commit that referenced this issue Jul 12, 2024
@r-bk
github: add a job to build rsdns with minimal toolchain
82cbc3b 
By default `dtolnay/rust-toolchain@v1` uses the `minimal` rustup profile
for toolchain installation.

This commit tests the fix for #3.
r-bk added a commit that referenced this issue Jul 12, 2024
@r-bk
github: add a job to build rsdns with no rustfmt
f8ab287 
By default `dtolnay/rust-toolchain@v1` uses the `minimal` rustup profile
for toolchain installation. However, seems like Actions bring some
pre-cached image with rustfmt installed. So this commit removes rustfmt
explicitly.

This commit tests the fix for #3.
r-bk added a commit that referenced this issue Jul 12, 2024
@r-bk
github: add a job to build rsdns with no rustfmt
6d06866 
By default `dtolnay/rust-toolchain@v1` uses the `minimal` rustup profile
for toolchain installation. However, seems like Actions bring some
pre-cached image with rustfmt installed. So this commit removes rustfmt
explicitly.

This commit tests the fix for #3.
r-bk added a commit that referenced this issue Jul 12, 2024
@r-bk
github: add a job to build rsdns with no rustfmt
7557c94 
By default `dtolnay/rust-toolchain@v1` uses the `minimal` rustup profile
for toolchain installation. However, seems like Actions bring some
pre-cached image with rustfmt installed. So this commit removes rustfmt
explicitly.

This commit tests the fix for #3.
r-bk added a commit that referenced this issue Jul 12, 2024
@r-bk
github: add a job to build rsdns with no rustfmt
c963f05 
By default `dtolnay/rust-toolchain@v1` uses the `minimal` rustup profile
for toolchain installation. However, seems like Actions bring some
pre-cached image with rustfmt installed. So this commit removes rustfmt
explicitly.

This commit tests the fix for #3.
r-bk added a commit that referenced this issue Jul 12, 2024
@r-bk
build: make code formatting a best-effort
4d65b24 
This commit makes the `format_file` function a best effort, to not fail
the build on toolchains where `rustfmt` isn't installed.

This handles #3.
r-bk added a commit that referenced this issue Jul 12, 2024
@r-bk
github: add a job to build rsdns with no rustfmt
5eaa90f 
By default `dtolnay/rust-toolchain@v1` uses the `minimal` rustup profile
for toolchain installation. However, seems like Actions bring some
pre-cached image with rustfmt installed. So this commit removes rustfmt
explicitly.

This commit tests the fix for #3.
r-bk added a commit that referenced this issue Jul 12, 2024
@r-bk
build: make code formatting a best-effort
ea82bcd 
This commit makes the `format_file` function a best effort, to not fail
the build on toolchains where `rustfmt` isn't installed.

This handles #3.
r-bk added a commit that referenced this issue Jul 12, 2024
@r-bk
github: add a job to build rsdns with no rustfmt
05447d1 
By default `dtolnay/rust-toolchain@v1` uses the `minimal` rustup profile
for toolchain installation. However, seems like Actions bring some
pre-cached image with rustfmt installed. So this commit removes rustfmt
explicitly.

This commit tests the fix for #3.
r-bk added a commit to r-bk/ch4 that referenced this issue Jul 12, 2024
@r-bk
build: make code formatting a best-effort
3f92814 
This commit makes the `format_file` function a best effort, to not fail
the build on toolchains where `rustfmt` isn't installed.

This commit follows r-bk/rsdns#3 to handle the
same issue in ch4.
r-bk added a commit to r-bk/ch4 that referenced this issue Jul 12, 2024
@r-bk
build: make code formatting a best-effort
3e495fd 
This commit makes the `format_file` function a best effort, to not fail
the build on toolchains where `rustfmt` isn't installed.

This commit follows r-bk/rsdns#3 to handle the
same issue in ch4.
r-bk added a commit to r-bk/ch4 that referenced this issue Jul 12, 2024
@r-bk
build: make code formatting a best-effort
e682645 
This commit makes the `format_file` function a best effort, to not fail
the build on toolchains where `rustfmt` isn't installed.

This commit follows r-bk/rsdns#3 to handle the
same issue in ch4.
@r-bk
Copy link
Owner

r-bk commented Jul 12, 2024

@qvignaud The issue is fixed in v0.18.0

@r-bk r-bk closed this as completed Jul 12, 2024
@qvignaud
Copy link
Author

Thank you very much! I will try it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qvignaud @r-bk