Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use_dbitest() #267

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: use_dbitest() #267

wants to merge 13 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Oct 13, 2022 •
edited

Draft, working towards inlining all tests in the packages. The longer-term plan is to make the tests self-contained and independent of DBItest.

Test locally e.g. with

R -q -e 'pkgload::load_all(); use_dbitest("../RSQLite")' && R CMD INSTALL --no-byte-compile . && R -q -e 'testthat::test_local("../RSQLite", filter = "^dbitest")'

Needs work on the new FIXMEs.

@krlmlr krlmlr mentioned this pull request Oct 13, 2022
Open
@krlmlr krlmlr requested a review from nbenn October 13, 2022 16:39
@krlmlr krlmlr mentioned this pull request Oct 13, 2022
Closed
@krlmlr krlmlr force-pushed the f-inline branch 4 times, most recently from fc02c97 to a821a19 Compare October 15, 2022 16:03
This was referenced Oct 16, 2022
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbenn nbenn Awaiting requested review from nbenn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@krlmlr