feat!: dbListObjects()
only allows Id()
objects as prefix
argument
#390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to only allow
Id()
objects asprefix
argument todbListObjects()
as mentioned in #372 (comment).prefix can now be a list with multiple
Id
objects, so querying all tables in all schemata a user has access to like this works:I am not sure, though, whether this was the intent for using
vlapply()
andvcapply()
here previously or whether I am missing good reasons against makingprefix
indbListObjects()
vectorised?Wouldn't it be cleaner though, to only have an
Id
method (and one forMISSING
) fordbListObjects()
instead of anANY
one? But that would require those changes be made to DBI (and other DBI-related packages), as well. I am probably missing something there as well.