-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
immediate argument to dbSendQuery() #272
Conversation
Should |
No, I think they should not use it unless it is requested. |
Otherwise I think it looks good, thanks! |
Thanks. I'll tweak and remove the "WIP" when ready. |
Ok, just ping me when you do so I don't miss it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting this to request changes until you have time to work on it @krlmlr
This is due to a bug in `DBI::dbAppendTable()` v1.0.0, which calls `dbExecute()` with `param` rather than `params`. r-dbi/DBI@b3c7158#diff-0e4e2142b6f1dc502f427b009aca4d60
Adds
params
andimmediate
arguments todbSendQuery()
(and, via dots,dbSendStatement()
,dbGetQuery()
anddbExecute()
). Uses SQLExecDirect ifimmediate
isTRUE
; in this case,params
are necessarily ignored.Currently a very quick-and-dirty proof of concept, will refine when we agree on the API.
Part of r-dbi/DBI#268.
Closes #163. Closes #127.
Created on 2019-04-16 by the reprex package (v0.2.1.9000)