Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-r gets r-version from renv.lock #701

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

iqis
Copy link
Contributor

@iqis iqis commented Feb 16, 2023

  • If user provides renv for r-version in setup-r, look for ./renv.lock.
    • if found, parse and use R version recorded within
    • if not, throw error

#700

* Update setup-r.ts

* build to js

* ...

* ...

* ...

* ...

* ...

* look for r version in renv.lock
version = core.getInput("r-version")

if (version === "renv") {
let renv_lock_path = "./renv.lock";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used . here as it will be resolved in the calling scope. Better way of doing this?

@codecov-commenter
Copy link

Codecov Report

Merging #701 (198e6f8) into v2-branch (ac4564f) will not change coverage.
The diff coverage is n/a.

❗ Current head 198e6f8 differs from pull request most recent head 339646c. Consider uploading reports for the commit 339646c to get more accurate results

@@             Coverage Diff             @@
##           v2-branch      #701   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi merged commit 1dc0ffb into r-lib:v2-branch Apr 1, 2023
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants