Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle setup-r action with ncc #840

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

gaborcsardi
Copy link
Member

So we don't need to include node_modules.

So we don't need to include node_modules.
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1aca174) to head (ecd186f).

Additional details and impacted files
@@             Coverage Diff             @@
##           v2-branch      #840   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Impossible to debug if minified.
It does not actually use r-lib/actions, so no point
having it here.
@gaborcsardi gaborcsardi merged commit f1e61bc into v2-branch May 7, 2024
28 checks passed
@gaborcsardi gaborcsardi deleted the feature/better-bundle branch May 7, 2024 17:12
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant