Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated cmark-gfm from 0.29.0.gfm.9 to .13; bumped up version to 1.9.2 #30

Merged
merged 4 commits into from
Jan 30, 2024
Merged

updated cmark-gfm from 0.29.0.gfm.9 to .13; bumped up version to 1.9.2 #30

merged 4 commits into from
Jan 30, 2024

Conversation

trbailey326
Copy link
Contributor

Everything appears to be working:

> remotes::install_github("trbailey326/commonmark@update-gfm-13")
> library(testthat)
> library(commonmark)
> test_check("commonmark")
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 19 ]

Extension tests passed as well.

@jeroen
Copy link
Member

jeroen commented Jan 26, 2024 •
edited
Loading

Can you remove the .in and .txt and ..re. files? We don't use those.

@jeroen jeroen merged commit 969e27e into r-lib:main Jan 30, 2024
5 checks passed
@jeroen
Copy link
Member

jeroen commented Jan 30, 2024

OK thanks I have submitted it to CRAN.

@trbailey326
Copy link
Contributor Author

Thanks - as someone who uses quite a few of the packages you have authored on a daily basis, I appreciate your work.

@infotroph infotroph mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trbailey326 @jeroen