Add dictionary argument to spell_check #1335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hadley may disagree, but I would prefer keeping this in |
|
Right, I don't disagree with that. Though it would be nice to run a full documentation spell check by default during CI builds and |
|
Let's leave it in suggests for now, and we can move into imports once we've extracted the stuff CI tools needs into a separate package. |
|
OK it's back in suggests now. |
hadley
reviewed
Nov 3, 2016
| @@ -60,6 +62,14 @@ release <- function(pkg = ".", check = TRUE, args = NULL) { | |||
| return(invisible()) | |||
| } | |||
|
|
|||
| if (length(spelling)) { | |||
There was a problem hiding this comment.
Can you please move this to check-devtools.r, following the template in release_checks()?
|
Thanks! Merged in 3af9cca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now use a custom language in
spell_checkfor example:Also
hunspellis now entirely self-contained (it has zero system dependencies) so I think we can just import it. Also added a feature that will automatically check documentation on release (as suggested by @hadley ).Hopefully this will encourage users to eliminate typo's from documentation :)