New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new parameter args to build_win, passed to build #421

Merged
merged 5 commits into from Mar 17, 2014

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Feb 10, 2014

No description provided.

R/build.r Outdated
pkg <- as.package(pkg)
# Maintaining both backward compatibility and same order of arguments as

This comment has been minimized.

@hadley

hadley Mar 17, 2014

Member

For this function, I think we can not worry about backward compatibility. (esp since you'd usually say quiet = T)

@krlmlr

This comment has been minimized.

Member

krlmlr commented Mar 17, 2014

Removed compatibility code and merged to master.

hadley added a commit that referenced this pull request Mar 17, 2014

Merge pull request #421 from krlmlr/build_win-args
new parameter args to build_win, passed to build

@hadley hadley merged commit efc7644 into r-lib:master Mar 17, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@hadley

This comment has been minimized.

Member

hadley commented Mar 17, 2014

Thanks. I'm also thinking about making the default to build on both r-release and r-devel. What do you think?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Mar 17, 2014

That would be great, hit me today when I forgot to ask about it. It seems that ftpUpload isn't vectorized, an extra lapply would be required.

I'll send a pull.

@hadley

This comment has been minimized.

Member

hadley commented Mar 17, 2014

Awesome, thanks.

@krlmlr krlmlr deleted the krlmlr:build_win-args branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment