Make dir_tree() work even when glob= or regexp= argument is supplied #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in #398.
dir_tree()
didn't work when a pattern was supplied toregexp=
orglob=
arguments that get passed on todir_ls()
. That's because the list of file paths returned by those calls todir_ls()
did not include paths of the parent (and grandparent etc.) directories thatdir_tree()
uses to construct the tree.The code I've added uses the file paths returned by
dir_ls()
to recreate the directory paths that'll be needed to build the tree.To see that this now works, try for example: