Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the result of resp_body_json() #351

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Cache the result of resp_body_json() #351

merged 4 commits into from
Oct 20, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Oct 17, 2023

Part of #341

@hadley hadley requested a review from mgirlich October 17, 2023 22:10
mgirlich
mgirlich reviewed Oct 19, 2023
View reviewed changes
R/resp-body.R Outdated Show resolved Hide resolved
mgirlich
mgirlich reviewed Oct 19, 2023
View reviewed changes
R/resp-body.R Outdated Show resolved Hide resolved
@mgirlich
Copy link
Collaborator

The caching obviously only works when using resp_body_json/xml() but I think this should cover most situations.

@hadley hadley merged commit 6b08573 into main Oct 20, 2023
12 checks passed
@hadley hadley deleted the cache-body branch October 20, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgirlich mgirlich mgirlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @mgirlich