Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting file backend to the default for RStudio Server [Pro] #95

Merged
merged 9 commits into from
Apr 23, 2021
Merged

Setting file backend to the default for RStudio Server [Pro] #95

merged 9 commits into from
Apr 23, 2021

Conversation

nwstephens
Copy link

This pull request sets the file backend by default on Linux servers where the secret service is not running.

On RStudio Server and RStudio Server Pro, keyring defaults to the env backend today by default, because the secret service is designed to run on desktops, not servers (see #53, #72, and #77). However, the file backend provides a superior experience to the env backend on the server. Users can store encrypted secrets to disk with the file backend, whereas the env backend only holds passwords for the life of the R session. The file backend throws no warnings, whereas the env backend throws warnings.

@codecov-commenter
Copy link

Codecov Report

Merging #95 (697b2f0) into master (7397e35) will increase coverage by 1.52%.
The diff coverage is 100.00%.

❗ Current head 697b2f0 differs from pull request most recent head 098e09a. Consider uploading reports for the commit 098e09a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   31.52%   33.05%   +1.52%     
==========================================
  Files          14       14              
  Lines        1180     1186       +6     
==========================================
+ Hits          372      392      +20     
+ Misses        808      794      -14     
Impacted Files Coverage Δ
R/backend-file.R 92.20% <100.00%> (+4.37%) ⬆️
R/default_backend.R 81.81% <100.00%> (-5.28%) ⬇️
R/api.R 35.29% <0.00%> (+5.88%) ⬆️
R/assertions.R 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7397e35...098e09a. Read the comment docs.

@gaborcsardi gaborcsardi merged commit e876c56 into r-lib:master Apr 23, 2021
@gaborcsardi
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants