Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indentation_linter thrown off by comment #1751

Closed
AshesITR opened this issue Oct 23, 2022 · 0 comments · Fixed by #1758
Closed

indentation_linter thrown off by comment #1751

AshesITR opened this issue Oct 23, 2022 · 0 comments · Fixed by #1758
Assignees
@AshesITR
Labels
bug an unexpected problem or unintended behavior

Comments

@AshesITR
Copy link
Collaborator

Is the indentation lint here a false positive? AFAICT, the indentation should be 6 spaces here.

Indentation should be 4 spaces but is 6 spaces.

Btw, if I try to inline this, I create line_length_linter() lint.

Originally posted by @IndrajeetPatil in #1748 (comment)

This should not lint:

a <- # comment
  42L
@AshesITR AshesITR added the bug an unexpected problem or unintended behavior label Oct 23, 2022
@AshesITR AshesITR added this to the 3.0.3 milestone Oct 23, 2022
@IndrajeetPatil IndrajeetPatil mentioned this issue Oct 24, 2022
Merged
@AshesITR AshesITR self-assigned this Oct 31, 2022
AshesITR added a commit that referenced this issue Oct 31, 2022
@AshesITR
fix #1751
8e84b23
@AshesITR AshesITR linked a pull request Oct 31, 2022 that will close this issue
Enhance and fix indentation_linter #1758
Merged
IndrajeetPatil pushed a commit that referenced this issue Nov 15, 2022
@AshesITR @MichaelChirico
Enhance and fix indentation_linter (#1758)
482402d 
* fix #1751

* fix #1754

* omit \cr

* more tests

* fix cyclocomp

* remove unnecessary Rd comment

* remove stray nolint end

* increase coverage, more tightly define always-hanging style

* line_length

Co-authored-by: Michael Chirico <chiricom@google.com>
@MichaelChirico MichaelChirico modified the milestones: 3.0.3, 3.1.0 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AshesITR AshesITR

Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance and fix indentation_linter r-lib/lintr
2 participants
@AshesITR @MichaelChirico