Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svTools linters #6

Closed
4 tasks done
jimhester opened this issue Oct 20, 2014 · 1 comment
Closed
4 tasks done

svTools linters #6

jimhester opened this issue Oct 20, 2014 · 1 comment
Labels
feature a feature request or enhancement

Comments

@jimhester
Copy link
Member

http://cran.r-project.org/web/packages/svTools/index.html

  • un-used local assignment
  • no visible binding for variable
  • no visible binding for function
  • multiple function definitions with different formal arguments

I'd like to suggest alternatives if possible as well.
@jimhester jimhester reopened this Oct 28, 2014
@jimhester
Copy link
Member Author

Still need to suggest alternatives to close this

@jimhester jimhester added feature a feature request or enhancement and removed enhancement labels May 17, 2018
MichaelChirico added a commit that referenced this issue May 21, 2024
@F-Noelle @MichaelChirico
Make scalar_in_linter() configurable (#2574)
e97be9b 
* Update scalar_in_linter.R (#1)

Make scalar_in_linter configurable to allow projects to define additional %in% style functions like %notin%.

* Incorporate review feedback (#2)

* Incorporate review feedback

- Use glue in xpath,
- Add changes to NEWS
- Change default for scalar_in_linter
- Make lint msg more open ended if another %in% operator was linted
- Update tests to match new bahaviour

* Add a vector of in operators (#3)

* Add a testcase based on configuration (#4)

* Improve lint message, NEWS, param documentation (#5)

* Improve lint message (#6)

* Update R/scalar_in_linter.R

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>

* Update lint message (#7)

---------

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimhester