Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #252: Allow plain-code-blocks in RMarkdown #349

Merged
merged 3 commits into from
Sep 18, 2018
Merged

fixes #252: Allow plain-code-blocks in RMarkdown #349

merged 3 commits into from
Sep 18, 2018

Commits on Sep 17, 2018

  1. fixes #252: Allow plain-code-blocks in RMarkdown

    Added a test to the end of test.Rmd that included a plain-code-block like this:
    
    ```
    This shouldn't cause a problem
    ```
    
    The code-block reproduced the `Malformed File` error described in #252
    
    Plain-blocks match the knitr `chunk.end` pattern at both the start and the end
    of the block. So when plain-blocks are present there was 2k _more_ chunk ends
    than starts.
    
    A small function `filter_chunk_end_positions` was added to filter the positions
    of the chunk-ends based on the chunk-starts
    russHyde committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    101e5f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. Configuration menu
    Copy the full SHA
    49d9826 View commit details
    Browse the repository at this point in the history
  2. reordered the functions

    Main function `extract_r_source` now precedes all it's helper functions (get_knitr_pattern, filter_chunk_end_positions, replace_prefix)
    russHyde committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    52a9f47 View commit details
    Browse the repository at this point in the history