Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rowidformat() #27

Merged
merged 9 commits into from
Aug 13, 2017
Merged

New rowidformat() #27

merged 9 commits into from
Aug 13, 2017

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Aug 8, 2017 •
edited
Loading

for formatting row IDs of tibbles. Not currently exported.

Test output: https://travis-ci.org/hadley/colformat/builds/262379740#L798

@krlmlr krlmlr requested a review from hadley August 8, 2017 19:17
@hadley
Copy link
Member

hadley commented Aug 8, 2017

I think they should be printed in pale gray. (Also the line number in your link is wrong)

hadley
hadley reviewed Aug 11, 2017
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Let's make a note to review class names before release. This seems a bit inconsistent:

 S3method(format,colformat)
 S3method(format,decimal_format)
 S3method(format,multicolformat)
 S3method(format,rif_data)

@krlmlr krlmlr mentioned this pull request Aug 13, 2017
Closed
@krlmlr krlmlr merged commit ec22936 into r-lib:master Aug 13, 2017
@krlmlr krlmlr deleted the f-rowid branch August 13, 2017 09:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hadley hadley hadley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @hadley