Downlit not run on articles?

[hadley]

e.g. https://googlesheets4.tidyverse.org/articles/articles/messages-and-errors.html

[maelle]

that vignette above is about unexported helpers, I see links in e.g. https://googlesheets4.tidyverse.org/articles/articles/write-sheets.html (but maybe I'm missing something else)

[hadley]

Oh I wasn't specific enough — in (e.g.) the output of the first chunk, we don't see any of the formatting applied by cli.

[maelle]

how should it look like?

[jennybc]

Here are screenshots 😱 that show what the interactive experience of this styling is. Note the colors of the cli symbols and that the symbols are not the same color as the text.

See how the main text is in white (or default color) and Sheet names are blue and worksheet or range names are green? These distinctions, between main text and styled text and between text styled 2 different ways (.file vs .field), are completely lost in this pkgdown article.

[jennybc]

It should look the same as it does in, say, examples:

https://googlesheets4.tidyverse.org/reference/range_read.html

Why do the vignettes and article not get same styling as examples? Here's another article where the messages are completely "flat".

https://googlesheets4.tidyverse.org/articles/articles/write-sheets.html

[maelle]

I learnt today that reference building uses downlit::evaluate_and_highlight() which makes it possible to parse messages/warnings/errors.

[maelle]

So fixing this issue might warrant adding downlit stuff in a knitr hook?

[maelle]

It might even be easier to set hooks for warnings and messages.

[hadley]

We could do this using the same technique as hugodown (e.g. hugdown:::knit_hooks), but I think it would be quite a bit of work, and I'm not sure how it would interact with HTML widgets or other custom options that folks might be using. The current implementation is rather hacky because knitr is not quite flexible enough.

[maelle]

was this/will it be somehow addressed by downlit recent changes?

[hadley]

It will be resolved.

[krlmlr]

FWIW I'm using https://github.com/tidyverse/tibble/blob/master/R/fansi.R as a stop gap for now.

[hadley]

If this happens will need to build README.Rmd ourselves.

[hadley]

This turned out to be much less complex than I had feared — it was mostly just turning crayon/cli on in articles, and then handling the pain of \033 in xml.