-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build_news needs specially formatted NEWS.md #1947
Comments
What also doesn't work is having all h2. Maybe it should work. |
Hey! I ran into what I think is the same issue with a GHA check on my Bioconductor R package: https://github.com/neurogenomics/MungeSumstats/runs/4522582120?check_suite_focus=true Is a fix likely to be released soon or is there a work around for time being? I'm constricted since Bioconductor enforces standards on the NEWS file |
Cf failure on https://github.com/r-universe/ropensci/runs/4511976106?check_suite_focus=true + pkgdown bug to be fixed r-lib/pkgdown#1947
I ran into this too with reticulate: https://raw.githubusercontent.com/rstudio/reticulate/main/NEWS.md
Presumedly because these are H2 rather than H1 headers. |
I'm having a similar issue, where some headers do not render. E.g. https://github.com/privefl/bigsnpr/blob/e72fa27b7bb4486b542505c46454ffcd21e5fa18/NEWS.md?plain=1#L71-L73 in https://github.com/privefl/bigsnpr/blob/e72fa27b7bb4486b542505c46454ffcd21e5fa18/docs/news/index.html#L155-L160. Problem is still there after updating to latest GitHub version of {pkgdown}. |
@privefl that header is for "bigsparser" but the package is "bigsnpr" hence its not being recognized. Side note: in general it's better to open a new issue. |
Yes, but I also want to show some important new releases from another package, of which my package is very dependent on. This was working with v1.6.1. |
Should I expect this not to be fixed? (i.e. working as with v1.6.1) |
@privefl you seem to expect a special case that was only ever supported by accident and we don’t plan to support going forward. |
In pkgdown 1.6.1,
build_news
rendered fine with any kind of heading. As in I could have NEWS.md containing:However, as of v 2.0.1, that seems to have changed. The above contents in NEWS.md will render an empty page. Instead, it has to be formatted like this in NEWS.md:
I'm not sure how many other people were using a simpler format of NEWS.md as I was, but it would be nice if the docs or vignette for
bulid_news
had more information on the required formatting.The text was updated successfully, but these errors were encountered: