-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for "target" in navbar components. #2089
Comments
I have a fork here: https://github.com/jschoenbachler/pkgdown I just added the following: Then modified the tag generation in the following places: Test snapshots don't need to be regenerated since we just pass a null variable if it isn't provided. |
Let me know if you want me to create a PR, or if anything else is needed for this to be a sufficient implementation. |
@maelle just pinging to see if I can get a quick answer on if I approached this correctly and can make a PR! |
@krlmlr Another ping just to see if this is an easy thing! |
@JSchoenbachler Thank you! You can open a PR as I see you've already made edits anyway. In general it's recommended to start PRs not from the main branch but from another branch. See e.g. https://happygitwithr.com/fork-and-clone.html#dont-touch-master As the edits you've made are small you might want to save them somewhere else, then start fresh in another branch so your fork's main branch is the same as the current r-lib/pkgdown main branch. To start PRs, usethis helpers are most useful, see https://usethis.r-lib.org/articles/pr-functions.html Noting that this issue is sort of related to #1630 |
Hey team, I was wondering if there could be a way to allow for the
target
tag to be specified on Navbar components?Our use case is that we want to include a link to our Lab's website in the navbar that opens in a new tab (by using
target=_blank
.The text was updated successfully, but these errors were encountered: