Support for "target" in navbar components.

[JSchoenbachler]

Hey team, I was wondering if there could be a way to allow for the target tag to be specified on Navbar components?

Our use case is that we want to include a link to our Lab's website in the navbar that opens in a new tab (by using target=_blank.

[JSchoenbachler]

I have a fork here: https://github.com/jschoenbachler/pkgdown

I just added the following:

https://github.com/JSchoenbachler/pkgdown/blob/205da3e1eafa9f0d68e62214ff2b128a343b214c/R/navbar.R#L203-L204

Then modified the tag generation in the following places:

https://github.com/JSchoenbachler/pkgdown/blob/205da3e1eafa9f0d68e62214ff2b128a343b214c/R/navbar.R#L256-L266

https://github.com/JSchoenbachler/pkgdown/blob/205da3e1eafa9f0d68e62214ff2b128a343b214c/R/navbar.R#L268-L277

Test snapshots don't need to be regenerated since we just pass a null variable if it isn't provided.

[JSchoenbachler]

Let me know if you want me to create a PR, or if anything else is needed for this to be a sufficient implementation.

[JSchoenbachler]

@maelle just pinging to see if I can get a quick answer on if I approached this correctly and can make a PR!

[JSchoenbachler]

@krlmlr Another ping just to see if this is an easy thing!

[maelle]

@JSchoenbachler Thank you! You can open a PR as I see you've already made edits anyway.
I can't say when it'll be reviewed (nor whether it will be merged) as activity in r-lib repos tends to happen in bursts. Thanks for your patience.

In general it's recommended to start PRs not from the main branch but from another branch. See e.g. https://happygitwithr.com/fork-and-clone.html#dont-touch-master As the edits you've made are small you might want to save them somewhere else, then start fresh in another branch so your fork's main branch is the same as the current r-lib/pkgdown main branch. To start PRs, usethis helpers are most useful, see https://usethis.r-lib.org/articles/pr-functions.html

Noting that this issue is sort of related to #1630