Nested paragraphs/empty paragraph in footer

[maelle]

I'm exploring a problem we're seeing in an rOpenSci package, where this line

pkgdown/R/render.R

Line 66 in 13d8d62

xml2::read_html(rendered, encoding = "UTF-8")

leads to errors such as

librdf error - HTML parser error: Tag nav invalid
librdf error - HTML parser error: Tag main invalid
librdf error - HTML parser error: Tag aside invalid
librdf error - HTML parser error: Tag footer invalid
librdf error - HTML parser error: Unexpected end tag : p
librdf error - HTML parser error: Unexpected end tag : p

Now for pkgdown itself there's no problem but I noticed that because we use markdown_text_block() for building elements of the footer, before that line we have

<div class="pkgdown-footer-left">
  <p><p>Developed by <a href="http://hadley.nz">Hadley Wickham</a>, <a href="https://hesselberthlab.org">Jay Hesselberth</a>, <a href="https://masalmon.eu">Maëlle Salmon</a>, <a href="https://www.posit.co"><img src="https://www.tidyverse.org/posit-logo.svg" alt="Posit" height="16" style="margin-bottom: 3px;"></a>.</p></p>
</div>

which is read by xml2, and then published, as

<div class="pkgdown-footer-left">
  <p></p>
<p>Developed by <a href="http://hadley.nz">Hadley Wickham</a>, <a href="https://hesselberthlab.org">Jay Hesselberth</a>, <a href="https://masalmon.eu">Maëlle Salmon</a>, <a href="https://www.posit.co"><img src="https://www.tidyverse.org/posit-logo.svg" alt="Posit" height="16" style="margin-bottom: 3px;"></a>.</p>
</div>

It doesn't seem to lead to any bug to have the empty paragraph, but to not produce nested paragraphs in the first place maybe

pkgdown/R/build-footer.R

Line 8 in 13d8d62

left <- markdown_text_block(paste0(components[structure$left], collapse = " "))

should use markdown_text_inline()?

[hadley]

If we fix that we'll also need to add some additional margin/padding to the default CSS since without that empty paragraph the footer text is very close to the border.

Are you sure that the problem isn't actually that the footer template includes <p> wrapping the content? I think that's the paragraph tag we want to remove so that it is possible for folks to create multiple paragraph footers if they really want to.