Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy to clipboard button doesn't change to Copied after copying #2462

Closed
olivroy opened this issue Apr 17, 2024 · 0 comments · Fixed by #2468
Closed

Copy to clipboard button doesn't change to Copied after copying #2462

olivroy opened this issue Apr 17, 2024 · 0 comments · Fixed by #2468
Milestone
2.0.9

Comments

@olivroy
Copy link
Collaborator

olivroy commented Apr 17, 2024

https://pkgdown.r-lib.org/dev/

Click on the Copy to clipboard button.

I am on Windows 10, using Edge.

It is minor as the value is actually copied in the clipboard, but still!

in quarto or on GitHub, you get the note "Copied!" after successfully copied to clipboard.

code
jayhesselberth added a commit that referenced this issue Apr 18, 2024
@jayhesselberth
update clipboard title target
55a02d6 
and bump clipboard.js version

fixes #2462
@jayhesselberth jayhesselberth mentioned this issue Apr 18, 2024
Merged
jayhesselberth added a commit that referenced this issue Apr 18, 2024
@jayhesselberth
update clipboard title target (#2468)
ef94cee 
and bump clipboard.js version

fixes #2462
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this issue Jun 1, 2024
@jayhesselberth @SebKrantz
update clipboard title target (r-lib#2468)
58bc7c0 
and bump clipboard.js version

fixes r-lib#2462
@olivroy olivroy added this to the 2.0.9 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.9
Development

Successfully merging a pull request may close this issue.

update clipboard title target r-lib/pkgdown
1 participant
@olivroy