Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greedy user linking in news items #902

Closed
jayhesselberth opened this issue Nov 19, 2018 · 0 comments
Closed

Greedy user linking in news items #902

jayhesselberth opened this issue Nov 19, 2018 · 0 comments
Labels
bug an unexpected problem or unintended behavior linking 📎 news 📰
Milestone
pkgdown 1.2.0

Comments

@jayhesselberth
Copy link
Collaborator

add_github_links() is currently too greedy.

Both @R and @username will be linked to github In a news item like this:

  • Fix Authors@R (@username)
@hadley hadley added this to the pkgdown 1.2.0 milestone Nov 19, 2018
@hadley hadley added bug an unexpected problem or unintended behavior news 📰 linking 📎 labels Nov 19, 2018
hadley added a commit that referenced this issue Nov 20, 2018
@hadley
Require whitespace or parens before author
605ebb3 
Fixes #902
@hadley hadley mentioned this issue Nov 20, 2018
Merged
hadley added a commit that referenced this issue Nov 20, 2018
@hadley
Require whitespace or parens before author (#904)
a475575 
Fixes #902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior linking 📎 news 📰
Projects
None yet
Milestone
pkgdown 1.2.0
Development

No branches or pull requests
2 participants
@hadley @jayhesselberth