Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greedy user linking in news items #902

Closed
jayhesselberth opened this issue Nov 19, 2018 · 0 comments
Closed

Greedy user linking in news items #902

jayhesselberth opened this issue Nov 19, 2018 · 0 comments

Comments

@jayhesselberth
Copy link
Collaborator

@jayhesselberth jayhesselberth commented Nov 19, 2018

add_github_links() is currently too greedy.

Both @R and @username will be linked to github In a news item like this:

  • Fix Authors@R (@username)
@hadley hadley added this to the pkgdown 1.2.0 milestone Nov 19, 2018
hadley added a commit that referenced this issue Nov 20, 2018
Fixes #902
@hadley hadley closed this in #904 Nov 20, 2018
hadley added a commit that referenced this issue Nov 20, 2018
Fixes #902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants