Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build_reference set interactive to FALSE #1708

Merged
merged 6 commits into from
Jun 3, 2021
Merged

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented May 25, 2021

Fix #1693

@maelle maelle requested a review from hadley May 25, 2021 13:41
@@ -12,7 +12,8 @@ highlight_examples <- function(code, topic, env = globalenv()) {
withr::local_options(list(
crayon.enabled = TRUE,
crayon.colors = 256,
device = function(...) ragg::agg_png(..., bg = bg)
device = function(...) ragg::agg_png(..., bg = bg),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminded me that we have testthat::local_reproducible_output(). I think we should also add:

  • cli.dynamic = FALSE
  • withr::local_envvar(RSTUDIO = NA)
  • withr::local_collate("C")

And add a comment reminding us of the link to testthat::local_reproducible_output() (which we probably don't want to depend on since that would create a hard requirement on tethtat)

@maelle maelle merged commit 01b49fb into master Jun 3, 2021
@maelle maelle deleted the ref-non-interactive branch June 3, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_reference should set interactive to FALSE
2 participants