docs: add alternative text to example of author configuration #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Oct 17, 2023
| @@ -63,7 +63,7 @@ and can contain `href` and/or `html` fields: | |||
| authors: | |||
| firstname lastname: | |||
| href: "http://name-website.com" | |||
| html: "<img src='https://website.com/name-picture.png' width=72>" | |||
| html: "<img src='https://website.com/name-picture.png' width=72 alt='Name Website'>" | |||
There was a problem hiding this comment.
Shouldn't this be more like "Name's logo" or "Photo of Name"?
There was a problem hiding this comment.
Or should it be empty #2288 (comment) 🤔
There was a problem hiding this comment.
Yeah, empty would be fine too. It's a bit hard to know since there's not much context here.
|
Could you please change the repo settings to make the "Update branch" button appear on the PR? |
|
Done! |
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2282
Maybe it'd also need a note on empty alternative text in case that's the best solution (reminded of this by #2288)