Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catalan translation #2333

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Add Catalan translation #2333

merged 7 commits into from
Oct 17, 2023

Conversation

jmaspons
Copy link
Contributor

No description provided.

Copy link

@llrs llrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! I have some comments. I hope it will be merged.

po/R-ca.po Outdated Show resolved Hide resolved
po/R-ca.po Outdated Show resolved Hide resolved

#: build-home-citation.R:91
msgid "Authors and Citation"
msgstr "Autors i citació"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use "Autors i cita" or even "Autors i referències"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

«cita» doesn't seem to have the proper meaning acoording to (dlc). «referències» could work as well as «citació» but should be in singular as it refers to the documented package only. In this case, I would leave the PR's original text.

po/R-ca.po Outdated Show resolved Hide resolved
@maelle
Copy link
Collaborator

maelle commented Aug 24, 2023

Moltes gràcies @jmaspons @llrs 💙

@jmaspons
Copy link
Contributor Author

Many thanks for your review, @llrs! I applied all your comments except for «Autors i citació». If you agree with the final result, we can merge

It's a pleasure to be able to comment on Catalan translations with others 😊

@jmaspons jmaspons requested a review from llrs August 28, 2023 10:25
Copy link

@llrs llrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jmaspons

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@hadley

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@hadley hadley merged commit 6638331 into r-lib:main Oct 17, 2023
13 checks passed
@hadley
Copy link
Member

hadley commented Oct 17, 2023

Thanks for working on this translation everyone!

@jmaspons jmaspons deleted the catalan branch October 18, 2023 07:55
@maelle
Copy link
Collaborator

maelle commented Oct 19, 2023

Thank you for taking the time @hadley 🙏

po/R-ca.po Show resolved Hide resolved
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants