Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "Citation" translation #2410

Merged
merged 3 commits into from
Mar 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

* Fix parsing of github profiles and issues into links when present at the beginning of list items (@pearsonca, #2122)
* Correct parse usage for S3 methods with non-syntactic class names (#2384).

* Deprecated `build_favicon()` was removed (`build_favicons()` remains).
* Use [cli](https://github.com/r-lib/cli) to provide interactive feedback.
* Preserve Markdown code blocks with class rmd from roxygen2 docs (@salim-b, #2298).
Expand All @@ -12,6 +11,7 @@
* Add Catalan translation (@jmaspons, #2333)
* Set RNG seed for htmlwidgets IDs. This reduces noise in pkgdown reference HTML output when examples generate htmlwidgets (@salim-b, #2294).
* Fix BS5 navbar template to get `navbar.type: dark` to work with bslib 0.6+ / Bootstrap 5.3+ (@tanho63, #2388)
* Translates citation sections (@eliocamp, #2410).
* Topic names that conflict with selector functions can now be listed as references in `_pkgdown.yml` (@dmurdoch, #2397).

# pkgdown 2.0.7
Expand Down
3 changes: 2 additions & 1 deletion R/build-home-citation.R
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ data_home_sidebar_citation <- function(pkg = ".") {
pkg <- as_pkgdown(pkg)

sidebar_section(
heading = "Citation",
heading = tr_("Citation"),
bullets = a(sprintf(tr_("Citing %s"), pkg$package), "authors.html#citation")
)
}
Expand Down Expand Up @@ -91,6 +91,7 @@ build_citation_authors <- function(pkg = ".") {

data <- list(
pagetitle = tr_("Authors and Citation"),
citationtitle = tr_("Citation"),
citations = data_citations(pkg),
authors = unname(data_authors(pkg)$all),
source = source
Expand Down
4 changes: 2 additions & 2 deletions inst/BS3/templates/content-citation-authors.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="contents col-md-9">
<div class="section level2 authors-section">
<div class="page-header">
<h1>Authors</h1>
<h1>{{pagetitle}}</h1>
</div>

{{{before}}}
Expand All @@ -18,7 +18,7 @@ <h1>Authors</h1>
</div>
<div class="section level2 citation-section">
<div>
<h1 id="citation">Citation</h1>
<h1 id="citation">{{citationtitle}}</h1>
{{#source}}<small class="dont-index">{{{.}}}</small>{{/source}}
</div>
</div>
Expand Down
Loading