Replace httr with httr2 #2600
Replace httr with httr2 #2600
Conversation
Also allows us to eliminate memoise since we can rely on httr2's HTTP caching instead :) Since I was in there, I also slightly tweaked the feedback from `build_favicons()`, since I was confused that it didn't print anything on completion.
| withCallingHandlers( | ||
| resp <- httr2::req_perform(req), | ||
| error = function(e) { | ||
| cli::cli_abort("API request failed.", parent = e) |
There was a problem hiding this comment.
I contemplated that too, but it ends up just echoing the url in the previous message, and the error will have build_favicon() in it, so I think it's pretty clear. (Plus I've never actually seen this fail, which is pretty remarkable)
R/build-home-index.R
Outdated
|
|
||
| if (!httr::http_error(cran_url)) { | ||
| req <- httr2::request(cran_url) | ||
| req <- httr2::req_cache(req, path = http_cache_dir(), max_age = 86400) |
There was a problem hiding this comment.
what is that age? maybe add a comment?
There was a problem hiding this comment.
I just assume everyone should know how many seconds are in a day 😆
There was a problem hiding this comment.
ok ok I'll try to remember about this magic number 😅
R/build-home-index.R
Outdated
| req <- httr::RETRY("HEAD", bioc_url, quiet = TRUE) | ||
| if (!httr::http_error(req) && !grepl("removed-packages", req$url)) { | ||
| req <- httr2::request(bioc_url) | ||
| req <- httr2::req_cache(req, path = http_cache_dir(), max_age = 86400) |
There was a problem hiding this comment.
could http_cache_dir() be called pkgdown_http_cache_dir()?
There was a problem hiding this comment.
I've refactored this to avoid the problem (and add a comment about the number of seconds 😄)
| if (!httr::http_error(req) && !grepl("removed-packages", req$url)) { | ||
| req <- httr2::request(bioc_url) | ||
| req <- httr2::req_cache(req, path = http_cache_dir(), max_age = 86400) | ||
| req <- httr2::req_error(req, function(resp) FALSE) |
There was a problem hiding this comment.
pkgdown imports magrittr but I suppose not having req as a pipeline is a preference? I was a bit surprised by the repeated explicit assignments.
There was a problem hiding this comment.
(here and in the other calls to httr2 functions)
There was a problem hiding this comment.
Using a pipe inside a package just feels weird to me. I might eliminate the relatively few remaining uses in pkgdown, since that would allow us to drop another dependency (which is useful since we're skating very close to the limit of 22)
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Also allows us to eliminate memoise since we can rely on httr2's HTTP caching instead :) Since I was in there, I also slightly tweaked the feedback from `build_favicons()`, since I was confused that it didn't print anything on completion.
Also allows us to eliminate memoise since we can rely on httr2's HTTP caching instead :)
Since I was in there, I also slightly tweaked the feedback from
build_favicons(), since I was confused that it didn't print anything on completion.