Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quiet = TRUE no longer works #213

Closed
hadley opened this issue Jun 7, 2022 · 1 comment · Fixed by #214
Closed

quiet = TRUE no longer works #213

hadley opened this issue Jun 7, 2022 · 1 comment · Fixed by #214

Comments

@hadley
Copy link
Member

hadley commented Jun 7, 2022 

> pkgload::load_all(quiet = TRUE)
ℹ Loading pkgload.
> pkgload::load_all(quiet = TRUE)
ℹ Loading pkgload.

I tried to fix this in load_all_quiet() but I don't understand the logic there. Maybe quiet needs to be set to NULL by default in order for this more complex logic to work?
@hadley hadley mentioned this issue Jun 7, 2022
Merged
lionel- added a commit that referenced this issue Jun 8, 2022
@lionel-
Fix quiet argument of load_all()
6351c9b 
Closes #213
@lionel- lionel- mentioned this issue Jun 8, 2022
Merged
lionel- added a commit that referenced this issue Jun 8, 2022
@lionel-
Fix quiet argument of load_all() (#214)
3985183 
Closes #213
@lionel-
Copy link
Member

lionel- commented Jun 8, 2022

The selective override needed a trailing %||% quiet. I've added comments and improved the naming to make the logic easier to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix quiet argument of load_all() r-lib/pkgload
2 participants
@hadley @lionel-