Add ps_disk_io_counters() for Windows and Linux
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 20, 2023 20:33
michaelwalshe
changed the title
ps_disk_io_counters() for Windows and Linux
|
Hi @gaborcsardi, have just updated the NEWS.md so this should be ready for review/merge now, please let me know if there's anything I need to change or update. |
- no need to 'perdisk' parameter, people can summarize a DF. - add stub for macos implementation - fix @examplesIf condition in manual - polish code style - move repeated tests to common tests
|
Thank you and sorry for the long wait! I adjusted it a bit, most importantly I removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
ps_disk_io_countersfor Linux and Windows based on psutil.Adds new functions
ps_disk_io_counters: Exported user-facing function, to return data.frame of disk IO counters. Takes 1 argument, perdisk, whether to return a total or 1 row per diskps__disk_io_counters_linux: Internal function for linux implementationps__disk_io_counters_windows: Internal function for windows implementationps__is_storage_device: Whether a device is a root or logical partition (linux)ps__read_procfs: Read disk stats from /proc/diskstats (linux)ps__read_sysfs: Fallback for if /proc/diskstats doesn't exist, reads from /sys/block (linux)Plus the following C function for windows:
ps__disk_io_counters: Internal function to return disk IO counters per diskImplementation of all functions heavily based on implementation from https://github.com/giampaolo/psutil/blob/master/psutil/_pslinux.py
User facing ps_disk_io_counters is tested, although not extensively as that requires mocking e.g. readLines which testthat currently cannot do.
Closes #145.