Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New windows version query in configure #70

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Conversation

gaborcsardi
Copy link
Member

Because the old one fails on non-English systems.

The code is now in an R file, so that we can test it better.

It tries to use wmic first. wmic should produce the same output,
irrespectively of the language. It wmic fails, e.g. because it is
not available, then we fall back to ver, but use a much more forgiving
regex. As long as the version number is the last word within square
brackets, this should work.

Closes #69

Because the old one fails on non-English systems.
@gaborcsardi gaborcsardi merged commit 12d0cd3 into master Jul 13, 2019
@gaborcsardi gaborcsardi deleted the fix/winver-parsing branch February 11, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install on Windows 7 fails
1 participant