Prepare for CRAN release #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* not sure if the function was ever called app_dirs but it is not presently
Needed by R CMD check (R-3.1.0).
* provides basic info about the package and ensures that ?rappdirs works.
* imports rather than depends should be sufficient * explicit import in NAMESPACE needed to make R 3.1.0 R CMD CHECK happy
* squashes a clang warning
Closed
|
Assuming those changes are acceptable, there are 2 smaller changesets waiting on top of that
The second changeset is an isolated version of the outstanding changes from @gaborcsardi's fork https://github.com/gaborcsardi/rappdirs. I'll prepare pull requests for those as and when. |
|
Looks great - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the package passes R CMD check on release and r-devel on windows, mac and ubuntu linux (travis). Each change is in a clearly isolated commit. The ones that might need a little look are: